bulk exit and remove validator #2185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SSV approve and setFeeRecipientAddress to the Native Staking Strategy's initialize function Correct the Natspec on how tx fees are handled.
Added fork tests to set MEV fee recipient Removed old native staking fork test file that is no longer being used
naddison36
requested review from
sparrowDom,
DanielVF and
shahthepro
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
+ Coverage 60.27% 60.88% +0.61%
==========================================
Files 72 72
Lines 3509 3513 +4
Branches 685 907 +222
==========================================
+ Hits 2115 2139 +24
+ Misses 1391 1371 -20
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Dependencies
The is to be deployed with
Code Change Checklist
To be completed before internal review begins:
Internal review: